Use readonly access modifier in MappingStrategy interface instead of … #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
nartc
pushed a commit
that referenced
this pull request
Jun 2, 2022
…instead of get. (#478) Co-authored-by: Joe Plahitko <joseph.plahitko@egov.com>
|
Thank you for the merge! Great work on this library, btw. It's really matured over time! |
|
@nartc - version 8.3.7 doesn't seem to be available when installing from npm, but I can see it's published on the npm registry site. Am I missing something? |
|
@jmplahitko what does it say for you? I was able to install it just fine here. |
|
@nartc hmm.. looks like this may be an issue with our private registry. I am able to pull it straight from npm. Thanks anyway! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using get keyword in ambient types may cause typescript errors in some build environments. Encountered the attached error when running a build using vue-cli in production mode. Tested locally and my changes in the pull request satisfies the TS compiler. PR need ASAP due to release train.
